[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 

Changes between Initial Version and Version 1 of Ticket #10396, comment 7


Ignore:
Timestamp:
04/16/18 15:51:46 (10 months ago)
Author:
tbishop
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10396, comment 7

    initial v1  
    33'''Dojo''' 
    44 
    5 This folder contains Dojo 1.7.2: 
    6  
    7         cldr/tools/SurveyConsole/WebContent/js/dojo 
    8  
    9 It seems mostly unused for anything related to this bug; at least its dojo.js function is unused. Some parts may be used elsewhere such as "js/dojo/dojox/widget/Standby/Standby.css" in cldr/tools/SurveyConsole/WebContent/index.html. Removing the folder doesn't seem to make any difference I've noticed, though. 
     5''[Note: SurveyConsole uses Dojo 1.7.2, but that's unrelated to this bug, which is in cldr-apps, not SurveyConsole.]'' 
    106 
    117This file links to Dojo 1.5 on ajax.googleapis.com: 
     
    1915        cldr/tools/cldr-apps/WebContent/WEB-INF/tmpl/ajax_status.jsp 
    2016 
    21 Removing WebContent/js/dojo, and changing 1.5 and 1.10.4 to 1.13.0 (the latest version other than 2.x) appears to cause no change: ST still works on Firefox and fails on Edge. Still, linking to three different Dojo versions, and hard-coding the version number in multiple places, isn't optimal. I propose to encapsulate the dependency by specifying the Dojo version and options in one place only, namely dojoheader.jspf, which can be included by about.jsp, browse.jsp, and ajax_status.jsp. 
     17Removing WebContent/js/dojo, and changing 1.5 and 1.10.4 to 1.13.0 (the latest version other than 2.x) appears to cause no change: ST still works on Firefox and fails on Edge. Still, linking to different Dojo versions, and hard-coding the version number in multiple places, isn't optimal. I propose to encapsulate the dependency by specifying the Dojo version and options in one place only, namely dojoheader.jspf, which can be included by about.jsp, browse.jsp, and ajax_status.jsp. 
    2218 
    2319Using the Edge debugging tools, including the profiler, there are clues suggesting that Dojo may be involved in causing an unwanted reload that goes back to the locale selection stage. However, the clues are hard to read since Dojo is minified. I plan to install the human-legible source for Dojo 1.13.0. That should make it clearer what's going on with Dojo when the bug occurs. There might be a bug in Dojo related to Edge compatibility. Or, we may need to revise our usage of Dojo to follow recommended current practices, such as AMD, async true. Even if the bug turns out not to be related to Dojo, modernizing is needed in the long run. Possibly related is this warning: "Use of XMLHttpRequest with the synchronous flag set to true is deprecated due to its impact on user-perceived site performance." I'm not sure what relation there is, if any, between async as in AMD, and async as in ajax. In the long run, we should get away from deprecated and legacy usages.