[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #11146(closed: fixed)

Opened 6 months ago

Last modified 6 weeks ago

fonts loaded over http, should be https

Reported by: srl Owned by: tbishop
Component: survey-backend Data Locale:
Phase: dsub Review: srl
Weeks: Data Xpath:
Xref:

Description

these should all be https ( the bootstrap entry was added manually)

bootstrap.min.css:@import url("http://fonts.googleapis.com/css?family=Open+Sans:400italic,700italic,400,700");/*!
redesign.css:@import url("http://fonts.googleapis.com/css?family=Noto+Sans:400italic,700italic,400,700");
redesign.css:@import url("http://fonts.googleapis.com/css?family=Noto+Sans+Symbols:400italic,700italic,400,700");

Attachments

T11146_before_fix.png (554.3 KB) - added by tbishop 4 months ago.
before fix
T11146_after_fix.png (442.4 KB) - added by tbishop 4 months ago.
after fix

Change History

comment:1 Changed 6 months ago by emmons

  • Status changed from new to accepted
  • Component changed from unknown to survey
  • Priority changed from assess to medium
  • Milestone changed from UNSCH to 34
  • Owner changed from anybody to tbishop
  • type changed from unknown to survey

comment:2 Changed 5 months ago by srl

So it looks like what we have i not bootstrap but bootswatch (looking at the comment). Bootswatch had the bug (i'll call it a bug) of using http instead of https or at least protocol relative, they fixed it in https://github.com/thomaspark/bootswatch/commit/979847f28d689bb93e5ff8cc9beb20a2a89c4f6b

I think we can replace our bootstrap.min.css with https://stackpath.bootstrapcdn.com/bootswatch/3.1.1/spacelab/bootstrap.min.css which seems to already have the fix ( http:// replaced with just // which is then protocol relative)

and write this down, because i had to do research to find that exact URL.

Last edited 5 months ago by srl (previous) (diff)

comment:3 Changed 5 months ago by tbishop

Work in progress is in branches/tbishop/t11146_fonts. It encapsulates the link in a new file bootstrap_css.jspf, included by v.jsp and ajax_status.jsp.

Complication: is the file base.tag used for anything, or is it dead code? Other than that, changes are ready. As Steven suggested, can get bootstrap.min.css from CDN instead of local file, it’s an update of bootstrap version so we should test more carefully than if we were only replacing http with https. -- CORRECTION: actually it's the same (old) version (3.1.1) of bootstrap.min.css so version change isn't a concern after all.

Last edited 4 months ago by tbishop (previous) (diff)

comment:5 Changed 4 months ago by tbishop

  • Status changed from accepted to reviewing
  • Review set to srl

I've committed the changes to trunk in revisions [14281] and [14282] (two commits since I forgot "svn add" for the first one). I'm testing on SmokeTest...

Last edited 4 months ago by tbishop (previous) (diff)

comment:6 Changed 4 months ago by srl

  • Status changed from reviewing to reviewfeedback

Still HTTP @ https://unicode.org/cldr/trac/browser/trunk/tools/cldr-apps/WebContent/css/redesign.css?#L1 (firefox may be a good test). Still OK to push but does not fix issue yet.

comment:7 Changed 4 months ago by tbishop

I've committed two more revisions [14283] and [14284]. I would have done better to learn how to run https on localhost. As I've just learned from Steven, this works:

npx local-ssl-proxy --source 8443 --target 8080

Then for example

https://localhost:8443/cldr-apps/v#locales///

can be used instead of

http://localhost:8080/cldr-apps/v#locales///

comment:8 Changed 4 months ago by tbishop

Testing on SmokeTest now shows the error messages are gone. I'm attaching "before" and "after" screenshots.

Changed 4 months ago by tbishop

before fix

Changed 4 months ago by tbishop

after fix

comment:9 Changed 4 months ago by tbishop

  • Status changed from reviewfeedback to reviewing

comment:10 Changed 6 weeks ago by srl

  • Status changed from reviewing to closed
  • Resolution set to fixed

Great. Are there followon tickets for the TODOs?

View

Add a comment

Modify Ticket

Action
as closed
Next status will be 'new'
Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.