[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search

CLDR Ticket #11154(closed: fixed)

Opened 5 months ago

Last modified 6 weeks ago

Error in VE currency coverage

Reported by: mark Owned by: emmons
Component: currency Data Locale:
Phase: rc Review: mark
Weeks: Data Xpath:


Description (last modified by mark) (diff)

I just got two failures in running the tests.

Error: (TestLocalCurrency.java:72) No current legal tender currency for locale: es_VE
Error: (TestSupplementalInfo.java:1494) Modern territory missing currency: [VE]

Here is the problem. We say that the 'from' field in the currency defaults to the start of the day, and the 'to' field defaults to the end of the day. http://unicode.org/reports/tr35/#Date_Ranges

But in SupplementalDataInfo.DateRange.java, which is what is used to parse the <currency> attributes in supplementalData.xml, that's not the way it works. The default 'to' time is also start of day. So current data like the following works — there is no point where VN doesn't have a currency (after 1978).

<region iso3166="VN">

<currency iso4217="VND" from="1985-09-14"/>
<currency iso4217="VNN" from="1978-05-03" to="1985-09-14"/>


For the data for VE that was just changed, the change was in accordance with the spec, but it actually leaves one day uncovered.

<region iso3166="VE">

<currency iso4217="VES" from="2018-06-04"/>
<currency iso4217="VEF" from="2008-01-01" to="2018-06-03"/>
<currency iso4217="VEB" from="1871-05-11" to="2008-06-30"/>


  1. So I recommend for now, changing VE to have to="2018-06-04", like the other cases. That fixes the problem, and the code won't detect a missing currency on 2018-06-03.
  1. We then have to decide whether to change the spec or change the data and code. So that we can see what the overall repercussions are, we also have to look at the other date range attributes (besides those in <currency>) to see if those have different defaults.
  1. We need to modify the tests so that all modern times are covered. That is, if the test hadn't been run today, the failure wouldn't have been caught.


Change History

comment:1 Changed 5 months ago by mark

  • Description modified (diff)

comment:2 Changed 5 months ago by mark

  • Review set to emmons

comment:3 Changed 5 months ago by mark

Not marked for review yet, because we need to resolve some other issues.

comment:4 Changed 5 months ago by emmons

  • Status changed from new to accepted
  • Component changed from unknown to currency
  • Priority changed from assess to major
  • Milestone changed from UNSCH to 34
  • Owner changed from anybody to emmons
  • type changed from unknown to data

comment:5 Changed 3 months ago by emmons

Not sure we came to a resolution on this. Did we decide to change all the data to comply with the spec? ( i.e. to = end of day )? This is probably the best answer. Even though we may cause some temporary problems, at least we will be consistent with the spec.

If so, then we could change the logic in SupplementalDataInfo.DateRange so that it is consistent.

comment:6 Changed 3 months ago by emmons

  • Review emmons deleted

comment:7 Changed 3 months ago by emmons

  • Phase changed from dsub to rc

comment:8 Changed 2 months ago by mark

I'm not sure that we should preserve the spec; it might cause more disruption than changing the spec to align with the data. That will take a bit of research into how ICU and other clients actually interpret the data.

I suggest that we not tackle this issue until and if we get everything else done for the release.

comment:9 Changed 2 months ago by emmons

  • Status changed from accepted to reviewing
  • Xref set to 11409
  • Review set to mark

Filed 11409 as a follow-up for the rest of this. We will need to close on this one in the current release. Not sure we can or should tackle the rest right now.

comment:10 Changed 6 weeks ago by mark

  • Status changed from reviewing to closed
  • Resolution set to fixed

Add a comment

Modify Ticket

as closed
Next status will be 'new'
Next status will be 'closed'

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.