[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #11427(reviewing)

Opened 4 months ago

Last modified 6 weeks ago

Disable most items in limited-submission release

Reported by: kristi Owned by: mark
Component: surveytool-other Data Locale:
Phase: dsub Review: tbishop
Weeks: Data Xpath:
Xref:

Description (last modified by mark) (diff)

For a release period where the contribution is only desired for certain locales and paths, we need a way to disable entry for certain paths and locales.

For examples, v35 would be scoped for only CLDR locales and a few locales with near 100% modern coverage, and even there, only:

  1. items where English changed (emoji, units, etc.)
  2. missing items (emoji, units, etc.)
  3. items with errors

Attachments

Change History

comment:1 Changed 4 months ago by kristi

  • Description modified (diff)

comment:2 Changed 4 months ago by kristi

for v35

  1. allow all locales only enabled for Emoji
  2. allow all data points for new locales: Hausa, Yoruba, Igbo,...
  3. allow all data points for existing locales for data correction: Maori, pt-PT, Mongolian
Last edited 4 months ago by kristi (previous) (diff)

comment:3 Changed 4 months ago by kristi

  • Owner changed from anybody to tbishop
  • Status changed from new to design
  • type changed from unknown to surveytool
  • Milestone changed from UNSCH to 35

comment:4 Changed 3 months ago by tbishop

  • Component changed from unknown to survey

comment:5 Changed 3 months ago by tbishop

Notes from meeting:

  • Core function is CheckCLDR.getShowRowAction
  • Results are sent to front end.
  • Consider making read-only lines gray rows. [Tom]
  • Need to extend to allow the locale to be passed in to getShowRowAction. [Tom] -- (Steven) Note that inner class DataSection.DataRow is-a PathValueInfo. The outer class DataSection already has a locale field (CLDRLocale locale;)  So we just need CLDRInfo.PathValueInfo interface to add a getLocale() (returning CLDRLocale) member that is implemented by returning DataSection.getLocale
  • Expand the function to allow us to easily do set of locales, paths, data driven [Mark]
  • Tom to file new ticket for his part, Mark for his part, Ticket #11427 is the global ticket.
  • Scope (tentative, needs a bit of investigation):
  1. allow all locales only enabled for Emoji (consider just U12 emoji + missing/errors if possible, otherwise all)
  1. allow all data points for new locales: Hausa, Yoruba, Igbo,... (team to decide on languages; Mark to communicate back to committee)
  1. allow all data points for existing locales for data correction: Maori, pt-PT, Mongolian
  1. ? allow adding missing data in Basic for CLDR modern locales ? (Mark to check out and report back)
  • Priority: need to get this done by early November; should start by late Oct.

comment:6 Changed 3 months ago by kristi

  • Priority changed from assess to critical

comment:7 Changed 3 months ago by tbishop

I've made the related ticket 11514 for the locale to be passed in to getShowRowAction.

comment:8 Changed 3 months ago by tbishop

  • Status changed from design to accepted

comment:9 Changed 3 months ago by tbishop

Changed from design to accepted per today's meeting with Mark and Kristi.

comment:10 Changed 2 months ago by tbishop

The question came up, whether getShowRowAction can detect errors/warnings about the currently winning value for a row. I think the answer is yes. Already getShowRowAction includes these lines:

            valueStatus = getValueStatus(winner, valueStatus);
            if (valueStatus != ValueStatus.NONE) {
                ...

Currently that's only executed under certain conditions, including that the user is not TC and the Phase is not SUBMISSION. Temporarily commenting out those conditions I verified that the code is reached, and valueStatus gets ValueStatus.ERROR if I've input a bogus value such as "BBB" for the first row at v#/aa/Numbering_Systems/. It should work fine to call getValueStatus wherever needed in getShowRowAction.

comment:11 Changed 2 months ago by mark

  • Owner changed from tbishop to mark

I'm taking this ticket for doing the low-level work, leveraging the results of ticket:11514

comment:12 Changed 2 months ago by mark

Just did two changes in https://unicode.org/cldr/trac/changeset/14629

(a) Make sure that SurveyMain loads the annotations for lastRelease files also.

It had:
File oldCommonA = new File(oldBase, "common/main");
File oldSeedA = new File(oldBase, "seed/main");

which feed into File roots[] = { oldCommon, oldSeed, oldCommonA, oldSeedA };

But that just duplicated oldCommon and oldSeed, so changed the /main to /annotations

(b) Change calling code so that we get the unresolved value (real or null) from the last release version. Counts inherited as missing (need to check that this doesn't have any other ramifications, since it affects voting also).

The old code was using a resolved cldr file for the old version. The downside of that was that there was always an inherited value, so we wouldn't see items that were missing. There is a by-product of this: the VoteResolver will treat inherited last-release values as missing. Should only have an effect on regional locales, but could make it easier to override inherited values, so have to check further.

comment:13 Changed 2 months ago by mark

We should probably also add the following, since they are new in English.

<listPattern type="standard-narrow">
<listPattern type="standard-short">

comment:14 Changed 2 months ago by mark

Added all paths with new values in English (about 30 emoji, 4 scripts, and narrow/short "and" list patterns

comment:15 Changed 2 months ago by mark

  • Cc pedberg, emmons added
  • Status changed from accepted to reviewing
  • Review set to tbishop

Tom, asking you to review changes since Peter is out.

comment:16 Changed 2 months ago by mark

  • Cc kristi, meike added

comment:17 Changed 2 months ago by mark

as per committee, adding 3 extra locales

comment:18 Changed 2 months ago by mark

  • Description modified (diff)
  • Summary changed from Survey tool ability to scope contribution paths to Disable of most items in limited-submission release

comment:19 Changed 2 months ago by mark

  • Summary changed from Disable of most items in limited-submission release to Disable most items in limited-submission release

comment:20 Changed 6 weeks ago by tbishop

There might be room for improvement here in getResolverInternal:

final Status lastStatus = lastValue == null ? Status.missing : getStatus(anOldFile, path, lastValue);

That logic might move into getStatus. If lastValue is null, then getStatus should return Status.missing. That way other callers of getStatus won't get bogus behavior. Actually getStatus is private and doesn't appear to have other callers currently; still the code would be cleaner.

comment:21 Changed 6 weeks ago by tbishop

The new function getOldFileUnresolved was added in [14629] but is unused since [14638]. It could be removed.

View

Add a comment

Modify Ticket

Action
as reviewing
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.