[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #4007(accepted)

Opened 7 years ago

Last modified 5 weeks ago

Clean up CLDRFile getExtraPaths

Reported by: mark Owned by: anybody
Component: perf Data Locale:
Phase: dsub Review:
Weeks: 0.4 Data Xpath:
Xref:

Description

CLDRFile has getExtraPaths as a hack compensating for the fact that plurals and dayPeriods need to be handled as a group, but in CLDR are broken up into separate paths. So what it does is to fill in the missing pieces, and (should) provide some hidden aliasing. For example, if we have

path/...[@count="other"]

Then it will generate the other paths with different count values appropriate for the locale, copying the values for "other".

This should be managed at a lower level so that it doesn't surface to the user of CLDR.

That is:

The results of getExtraPaths should just be returned by the iterator as normal, and then getExtraPaths return an empty set. Once that is working, then the callsites can be fixed, and the methods removed.

getStringValue and getFullXPath should return the appropriate default values for counts. For dayPeriods, we need to discuss the right approach.

Attachments

Change History

comment:1 Changed 7 years ago by mark

  • Owner changed from somebody to mark
  • Priority changed from assess to major
  • Status changed from new to assigned
  • Component changed from unknown to tools
  • Milestone changed from UNSCH to 21

comment:2 Changed 7 years ago by mark

  • Keywords google added

comment:3 Changed 7 years ago by mark

  • Weeks set to 0.4
  • Milestone changed from 21 to 22

comment:4 Changed 5 years ago by mark

  • Component changed from tools to perf
  • Milestone changed from future to 25rc

comment:5 Changed 5 years ago by mark

  • Milestone changed from 25rc to 25final

comment:6 Changed 5 years ago by mark

  • Milestone changed from 25final to 26dsub

comment:7 Changed 5 years ago by mark

  • Owner changed from mark to ribnitz

ticket:4632, ticket:5973, ticket:4007, and ticket:6303 are all connected, and should be done together.

Needs design doc.

comment:8 Changed 5 years ago by emmons

  • Milestone changed from 26dsub to 26dvet

Moving all 26dsub to 26dvet. Please assess the need to complete tickets by 26dvet, which is 2014-06-19

comment:9 Changed 5 years ago by ribnitz

  • Status changed from assigned to reviewing
  • Review set to mark

Cleaned up getExtraPaths: now returns an empty set; the no-argument iterator will also include the paths not in the current CLDRFile, these are generated and filtered from the set of all possible paths; some caching is done in the process.

comment:10 Changed 5 years ago by mark

  • Status changed from reviewing to accepted

This doesn't really do what is needed. Let's discuss in person.

comment:11 Changed 4 years ago by mark

  • Owner changed from ribnitz to googler

comment:12 Changed 4 years ago by mark

  • Milestone changed from 26dvet to 27dsub

comment:13 Changed 4 years ago by markus

  • Phase set to dsub
  • Milestone changed from 27dsub to 27

comment:14 Changed 4 years ago by emmons

  • Review mark deleted

comment:15 Changed 4 years ago by emmons

  • Milestone changed from 27 to UNSCH

comment:16 Changed 5 weeks ago by mark

  • Owner changed from googler to anybody
View

Add a comment

Modify Ticket

Action
as accepted
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.