[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #5119(accepted tools)

Opened 5 years ago

Last modified 2 years ago

CLDRFile extrapaths misses breton's "many"

Reported by: srl Owned by: mark
Component: unknown Data Locale:
Phase: Review:
Weeks: Data Xpath:
Xref:

Description

Why does CLDRFile.getExtraPaths() use this code:

final Set<Count> pluralCounts = supplementalData.getPlurals(getLocaleID()).getCountToExamplesMap().keySet();

instead of:

supplementalData.getPlurals(getLocaleID()).getCanonicalKeywords()

I think it misses 'many' because the example counter only goes up to 1000.

Attachments

Change History

comment:1 Changed 5 years ago by srl

Argh, it was the "for .. <1000" loop. Changing to 1000001 caused Many to show up.

it looks like the function in question effectively just skips "0" and "1" (besides anything else not less than 1000). Perhaps better to just explicitly skip 0 and 1?

comment:2 Changed 5 years ago by mark

We're going to be dropping the "0" and "1" cases from the data. In conjunction with that (could be done earlier), we should remove the following code from SupplementalDataInfo.

            Set<String> temp = new LinkedHashSet<String>();
            String keyword = pluralRules.select(0.0d);
            double value = pluralRules.getUniqueKeywordValue(keyword);
            if (value == pluralRules.NO_UNIQUE_VALUE) {
                temp.add("0");
            }
            keyword = pluralRules.select(1.0d);
            value = pluralRules.getUniqueKeywordValue(keyword);
            if (value == pluralRules.NO_UNIQUE_VALUE) {
                temp.add("1");
            }

comment:3 Changed 5 years ago by emmons

  • Status changed from new to assigned
  • Component changed from unknown to tools
  • Priority changed from critical to major
  • Milestone changed from UNSCH to 22
  • Owner changed from anybody to mark
  • Type changed from unknown to defect

comment:4 Changed 5 years ago by mark

  • Milestone changed from 22 to 23dsub

comment:5 Changed 5 years ago by emmons

  • Milestone changed from 23dsub to 23dres

comment:6 Changed 5 years ago by mark

  • Milestone changed from 23dres to cleanup

comment:7 Changed 2 years ago by markus

  • Type changed from defect to tools
  • Component changed from tools to unknown

comment:8 Changed 2 years ago by srl

  • Status changed from assigned to accepted
View

Add a comment

Modify Ticket

Action
as accepted
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.