[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #6002(accepted unittest)

Opened 4 years ago

Last modified 2 years ago

Add build tests to check code for new data items

Reported by: jchye Owned by: anybody
Component: unknown Data Locale:
Phase: dsub Review:
Weeks: Data Xpath:
Xref:

Description

When adding new items to the CLDR data, most of the following have to be added to the tools as well:

  • examples
  • path header
  • path description
  • placeholder description
  • LDML-ICU conversion

If we added tests to the build to check that all these were added along with new data items, we'd save time doublechecking that nothing was missed and avoid issues like cldrbug 6001 and cldrbug 5980.

We could have a test that loads a regex file with exceptions for data items that don't require some of the abovementioned code changes. Example format:

//ldml/localeDisplayNames/territories/territory[@type="%A"] ; placeholder ; example

Placeholders are probably already covered by CheckExemplars though, so they could be left out of this test.

Attachments

Change History

comment:1 Changed 4 years ago by srl

could use @annotations with an xpath regex on classes, to mark them as applying for examples:

   @CLDRExample("//ldml/shoeSize")
   class ShoeSizeExample { 
     ...
   }

and have a 'Null Example' that is added to for things that don't need an example.

otherwise, in a file, you could list a class or function name, and call it via reflection (reflect all of the items at startup, of course)

comment:3 Changed 4 years ago by emmons

  • Owner changed from anybody to jchye
  • Priority changed from assess to medium
  • Type changed from unknown to enhancement
  • Status changed from new to assigned
  • Milestone changed from UNSCH to 25dsub

comment:4 Changed 3 years ago by emmons

  • Milestone changed from 25dsub to 25rc

Moving all 25dsub and 25design tickets to 25rc. If you plan to complete items in the 25M1 time frame, please move those tickets to 25M1.

comment:5 Changed 3 years ago by mark

  • Owner changed from jchye to googler

comment:6 Changed 3 years ago by emmons

  • Milestone changed from 25rc to 26rc

comment:7 Changed 3 years ago by mark

  • Owner changed from googler to anybody
  • Milestone changed from 26rc to 27dsub

comment:8 Changed 3 years ago by markus

  • Phase set to dsub
  • Milestone changed from 27dsub to 27

comment:9 Changed 2 years ago by emmons

  • Component changed from unknown to test

comment:10 Changed 2 years ago by emmons

  • Milestone changed from 27 to UNSCH

Moving all anybody+27 tickets to UNSCH

comment:11 Changed 2 years ago by markus

  • Type changed from enhancement to unittest
  • Component changed from test to unknown

comment:12 Changed 2 years ago by srl

  • Status changed from assigned to accepted
View

Add a comment

Modify Ticket

Action
as accepted
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.