[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #6093(accepted tools)

Opened 4 years ago

Last modified 19 months ago

Misnamed or incorrect childOf

Reported by: mark Owned by: srl
Component: util Data Locale:
Phase: dsub Review:
Weeks: Data Xpath:
Xref:

Description

Stumbled over misnamed or incorrect childOf

   /**
     * Returns true if other is equal to or is an ancestor of this, false otherwise
     */
    public boolean childOf(CLDRLocale other) {

Should either be named

  1. isChildOf, and return false if this == other, or
  2. isChildOfOrSame, and return true if this == other

Attachments

Change History

comment:1 Changed 4 years ago by srl

good catch. could be isChildOfOrSame and return true if this == other. Usages is in DAIP and replaces code that was doing a substring match.

./unicode/cldr/test/DisplayAndInputProcessor.java:            if (locale.childOf(MALAYALAM)) {
./unicode/cldr/test/DisplayAndInputProcessor.java:            } else if (locale.childOf(ROMANIAN) && !path.startsWith("//ldml/cha
}}

comment:2 Changed 4 years ago by emmons

  • Status changed from new to assigned
  • Component changed from unknown to tools
  • Priority changed from assess to medium
  • Milestone changed from UNSCH to 24dsub2
  • Owner changed from anybody to srl
  • Type changed from unknown to defect

comment:3 Changed 4 years ago by srl

  • Milestone changed from 24dsub2 to 25dsub

triage

comment:4 Changed 3 years ago by emmons

  • Milestone changed from 25dsub to 25M1

Moving all 25dsub to 25M1. Please adjust the milestone if you are not planning to complete the item in the 25M1 time frame.

comment:5 Changed 3 years ago by srl

  • Milestone changed from 25M1 to 25rc

comment:6 Changed 3 years ago by srl

  • Milestone changed from 25rc to 26dsub

rolling

comment:7 Changed 3 years ago by srl

  • Milestone changed from 26dsub to 26dvet

comment:8 Changed 3 years ago by srl

  • Milestone changed from 26dvet to 27dsub

roll

comment:9 Changed 3 years ago by markus

  • Phase set to dsub
  • Milestone changed from 27dsub to 27

comment:10 Changed 2 years ago by srl

  • Milestone changed from 27 to 28

roll

comment:11 Changed 2 years ago by markus

  • Type changed from defect to tools
  • Component changed from tools to unknown

comment:12 Changed 2 years ago by srl

  • Status changed from assigned to accepted

comment:13 Changed 20 months ago by emmons

  • Component changed from unknown to util

comment:14 Changed 19 months ago by emmons

  • Milestone changed from 28 to 28roll

Moving all outstanding 28 tickets to 28roll. We will discuss disposition of these at the next CLDR TC.

View

Add a comment

Modify Ticket

Action
as accepted
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.