[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #6406(accepted enhancement)

Opened 4 years ago

Last modified 3 years ago

Clean up error/warning messages

Reported by: mark Owned by: anybody
Component: survey Data Locale:
Phase: dsub Review:
Weeks: Data Xpath:
Xref:

ticket:6386

Description

We should show the details for the types of warnings in the VettingViewer, because they may have very different priorities. See mock at http://unicode.org/repos/cldr-tmp/trunk/dropbox/mark/vetting/vettingView-summary-google.html

There are two followups for this.

  1. Some of the subtypes are used for rather different kinds of warning messages. We should have a consistent warning message for each different subtype so that these are consistent for the user. We can add subtypes to make this happen.
  1. The warning message can always be prefaced with the subtype, to make a logical connection between the subtotals in the mock and the warning messages. Examples:

The characters ‎[,]‎ should not be used in this context. For what to do, see Handling Warnings in Characters.
=>
Discouraged characters. The characters ‎[,]‎ should not be used in this context. For what to do, see Handling Warnings in Characters.

See 6386

Attachments

Change History

comment:1 Changed 4 years ago by emmons

  • Status changed from new to assigned
  • Component changed from unknown to survey
  • Priority changed from assess to medium
  • Milestone changed from UNSCH to 25dsub
  • Owner changed from anybody to mark
  • Type changed from unknown to enhancement

comment:2 Changed 4 years ago by emmons

  • Milestone changed from 25dsub to 25rc

Moving all 25dsub and 25design tickets to 25rc. If you plan to complete items in the 25M1 time frame, please move those tickets to 25M1.

comment:3 Changed 4 years ago by mark

  • Owner changed from mark to ribnitz

This will take some thought, so talk to me before starting.

comment:4 Changed 4 years ago by mark

The basic idea is that we take each subtype and incorporate the calling information into the subtype.

For each subtype in CheckCLDR.Subtype

If it is used 0 times, remove it.

If it is used 2+ times, put a proposal (for all of these) into a doc for how to separate the meanings.

If it is used exactly 1 time, move its args into the definition. For example, CheckCLDR.Subtype.valueAlwaysOverridden occurs once.

CheckStatus item = new CheckStatus().setCause(this).setMainType(CheckStatus.errorType)

.setSubtype(Subtype.valueAlwaysOverridden)
.setCheckOnSubmit(false)
.setMessage("Value always overridden in children: {0}", new Object[] { tempSet.keySet().toString() });

Change the definition from

incorrectCasing, valueAlwaysOverridden, nullChildFile, internalError, coverageLevel,

to

incorrectCasing...
valueAlwaysOverridden(CheckStatus.errorType, false, "Value always overridden in children: {0}"),
nullChildFile...

Change the call site to:

CheckStatus item = new CheckStatus(this, Subtype.valueAlwaysOverridden, tempSet.keySet().toString());

Change CheckStatus.getMessage, etc. to get info out of the Subtype.

comment:5 Changed 4 years ago by emmons

  • Milestone changed from 25rc to 25final

comment:6 Changed 4 years ago by mark

  • Milestone changed from 25final to 26dsub

comment:7 Changed 4 years ago by emmons

  • Milestone changed from 26dsub to 26dvet

Moving all 26dsub to 26dvet. Please assess the need to complete tickets by 26dvet, which is 2014-06-19

comment:8 Changed 3 years ago by mark

  • Owner changed from ribnitz to googler

comment:9 Changed 3 years ago by mark

  • Owner changed from googler to anybody
  • Milestone changed from 26dvet to 27dsub

comment:10 Changed 3 years ago by markus

  • Phase set to dsub
  • Milestone changed from 27dsub to 27

comment:11 Changed 3 years ago by emmons

  • Milestone changed from 27 to UNSCH

Moving all anybody+27 tickets to UNSCH

comment:12 Changed 3 years ago by srl

  • Status changed from assigned to accepted
View

Add a comment

Modify Ticket

Action
as accepted
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.