[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #6519(closed enhancement: fixed)

Opened 5 years ago

Last modified 4 years ago

ICU converter: process ULI exception data

Reported by: srl Owned by: jali01
Component: xxx-tools Data Locale:
Phase: Review: srl
Weeks: Data Xpath:
Xref:

ticket:6336

ticket:5565

ticket:6519

Description (last modified by srl) (diff)

convert ticket:6336 exception data into ICU format. Depends on break iteration using new ldml2icu converter.

Attachments

ulibrk.patch (3.2 KB) - added by srl 5 years ago.
WIP. Depends on other brk work.

Change History

comment:1 Changed 5 years ago by srl

  • Description modified (diff)

comment:2 Changed 5 years ago by srl

Changed 5 years ago by srl

WIP. Depends on other brk work.

comment:3 Changed 5 years ago by emmons

  • Status changed from new to assigned
  • Component changed from unknown to tools
  • Priority changed from assess to minor
  • Milestone changed from UNSCH to 24rc
  • Owner changed from anybody to srl
  • Type changed from unknown to enhancement

comment:4 Changed 5 years ago by srl

  • Milestone changed from 24rc to 25dsub

rolling due to time

comment:5 Changed 5 years ago by srl

  • Cc srl, jchye added
  • Owner changed from srl to jali01

comment:6 Changed 5 years ago by srl

  • Xref changed from 6336 to 6336 5565

For reference: was blocked by ticket:5565 and IcuBug:10252

comment:7 Changed 5 years ago by srl

NB for Jonathan:

  • Due to historical oddities and odd design choices, which still don't make sense the 100th time they have been explained to me, the ICU break iterator files are actually not generated from CLDR. char.txt and sent_el.txt are NOT built from CLDR's root.xml and el.xml, but are manually converted from them. The ICU xml files in icu/source/data/xml/brkiter/*.xml come into play to control how the inclusions of the char.txt and sent_el.txt, etc, happen.
  • Because of the above, I don't know if it will require some code changes in the generator for ICU to suddenly have a brkiter/es.txt (say) brkiter file due to the existence of <cldr>/segments/es.xml. I don't think the generators actually even looked at CLDR's segments directory! Look at the args, in icu's build.xml as to how generic locale data is generated:
                        <arg name="--sourcedir"       value="${env.CLDR_DIR}/common/main" />
                        <arg name="--destdir"         value="${env.ICU4C_DIR}/source/data/locales"/>
                        <arg name="--specialsdir"     value="${env.ICU4C_DIR}/source/data/xml/main"/>
    
    but brkiter is generated with:
                        <arg name="--sourcedir"       value="${env.ICU4C_DIR}/source/data/xml/brkitr"/>
                        <arg name="--destdir"         value="${env.ICU4C_DIR}/source/data/brkitr"/>
    
    so the source dir is the ICU data, NOT the CLDR data. This probably should change to be more similar to the general locale data is generated, so --sourcedir points to CLDR's common/segments, and move the xml/brkiter to be the --specialsdir . Generator may complain about disjunction between the set of locales in CLDR/segments and ICU/xml/brkiter. Check carefully the set of files generated.
  • Probably a good output format in icu/source/data/brkiter/*.txt would be something like this:
    en {
     exceptions {
       sentence:array {
          "Maj."
          "Mr."
          // ...
       }
     }
    }
    

comment:8 Changed 5 years ago by jali01

  • Review set to srl

comment:9 Changed 5 years ago by jali01

  • Review srl deleted

comment:10 Changed 5 years ago by jali01

Code ready, just awaiting merge to trunk

comment:11 Changed 4 years ago by jali01

  • Review set to srl

comment:12 Changed 4 years ago by emmons

  • Milestone changed from 25dsub to 25M1

Moving all 25dsub to 25M1. Please adjust the milestone if you are not planning to complete the item in the 25M1 time frame.

comment:13 Changed 4 years ago by pedberg

  • Xref changed from 6336 5565 to 6336 5565 6519

Followup task in cldrbug 6519:

comment:14 Changed 4 years ago by srl

  • Status changed from assigned to reviewing

comment:15 Changed 4 years ago by srl

  • Status changed from reviewing to closed
  • Resolution set to fixed

comment:16 Changed 4 years ago by emmons

  • Milestone 25M1 deleted

Milestone 25M1 deleted

View

Add a comment

Modify Ticket

Action
as closed
Next status will be 'new'
Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.