[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #6522(accepted tools)

Opened 4 years ago

Last modified 23 months ago

Revisit use of CLDRFile.GEN_VERSION

Reported by: srl Owned by: srl
Component: util Data Locale:
Phase: dsub Review:
Weeks: Data Xpath:
Xref:

Description

Search for and revisit use of CLDRFile.GEN_VERSION

For generating new files, it's OK. However, for converters such as to ICU or JSON format, I think it is inappropriate, as the actual DTD version being processed should be used in case the code and data are a different version.

If this desync is concerning, then I would actually assert that the DTD version matches the GEN_VERSION.

Either way, I don't think we should blindly write the CLDRFile.GEN_VERSION out when we are processing input CLDR files.

See ticket:6521 - I've added a function to read the DTD.

Attachments

Change History

comment:1 Changed 4 years ago by emmons

  • Status changed from new to assigned
  • Component changed from unknown to tools
  • Priority changed from assess to medium
  • Milestone changed from UNSCH to 25rc
  • Owner changed from anybody to srl
  • Type changed from unknown to enhancement

comment:2 Changed 4 years ago by jchye

I think we should be able to replace most (if not all) uses of CLDRFile.GEN_VERSION with CLDRFile.getDTDVersion(). It'd be more efficient than calling a separate function to parse the DTD.

comment:3 Changed 3 years ago by srl

  • Milestone changed from 25rc to 26dsub

rolling

comment:4 Changed 3 years ago by srl

  • Milestone changed from 26dsub to 26dvet

comment:5 Changed 3 years ago by srl

  • Milestone changed from 26dvet to 27dsub

roll

comment:6 Changed 3 years ago by markus

  • Phase set to dsub
  • Milestone changed from 27dsub to 27

comment:7 Changed 2 years ago by srl

  • Milestone changed from 27 to 28

roll

comment:8 Changed 2 years ago by markus

  • Type changed from enhancement to tools
  • Component changed from tools to unknown

comment:9 Changed 2 years ago by srl

  • Status changed from assigned to accepted

comment:10 Changed 2 years ago by emmons

  • Component changed from unknown to util

comment:11 Changed 23 months ago by emmons

  • Milestone changed from 28 to 28roll

Moving all outstanding 28 tickets to 28roll. We will discuss disposition of these at the next CLDR TC.

View

Add a comment

Modify Ticket

Action
as accepted
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.