[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #6563(closed defect: fixed)

Opened 2 years ago

Last modified 23 months ago

Fix lingering references to old <fields> location

Reported by: pedberg Owned by: pedberg
Component: xxx-tools Data Locale:
Phase: Review: emmons
Weeks: Data Xpath:
Xref:

Description

The <fields> element was moved from

  • ldml/dates/calendars/calendar[type=*]/fields/

to

  • ldml/dates/fields/

but many references/usages were not updated to reflect this:

  1. tools/java/org/unicode/cldr/test/IdToPath.java, all 27 references at the old location, e.g.:
    {"6105184699793018548","//ldml/dates/calendars/calendar[@type=\"gregorian\"]/fields/field[@type=\"day\"]/displayName","Day",}
    
  2. tools/java/org/unicode/cldr/unittest/data/xmb/en.xml, all 27 references (just comments) at the old location
  3. tools/java/org/unicode/cldr/unittest/TestCoverageLevel.txt, the only reference is to the old location:
    ^//ldml/dates/calendars/calendar\[@type=".*"]/fields/field\[@type=".*"]/relative\[@type="([-]?[23])"] ; 80
    
  4. tools/java/org/unicode/cldr/util/data/paths/missingOk.txt, the only reference is to the old location:
    //ldml/dates/calendars/calendar[@type="%A"]/fields/field[@type="day"]/relative[@type="-?2"]; ok
    
  5. tools/java/org/unicode/cldr/util/DateTimeFormats.java, set still uses the old path for unit display names, but RelativePattern uses the new path for relative units.
  6. The spec table at http://www.unicode.org/reports/tr35/tr35-general.html#Context_Transform_Elements gives the old path

Attachments

Change History

comment:1 Changed 2 years ago by emmons

  • Owner changed from anybody to pedberg
  • Priority changed from assess to medium
  • Status changed from new to assigned
  • Milestone changed from UNSCH to 24final

comment:2 Changed 23 months ago by pedberg

  • Cc mark, srl added
  • Status changed from assigned to accepted
  • Review set to emmons

My only question at this point is: In tools/java/org/unicode/cldr/test/IdToPath.java, do we need to keep the old entries around for backward compatibility (I have at least added comments indicating they are deprecated), or can we just delete them entirely? I am not sure how IdToPath is used (it is invoked by ConvertXTB and GenerateXMB, but I am not sure what *those* are used for).

comment:3 Changed 23 months ago by emmons

  • Status changed from accepted to closed
  • Resolution set to fixed
View

Add a comment

Modify Ticket

Action
as closed
The ticket will be disowned. The resolution will be deleted. Next status will be 'new'
Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.