[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #6910(accepted enhancement)

Opened 3 years ago

Last modified 20 months ago

Remove the attribute comparator

Reported by: mark Owned by: mark
Component: infrastructure Data Locale:
Phase: rc Review:
Weeks: Data Xpath:
Xref:

Description

The default attribute comparator is created with a static function. That's a problem, because it is only really relevant for the ldml DTD (and there we have to hack it to actually return the ldmlIcu DTD!).

This is fragile, since it is used by low-level functions like XPathParts that are used with DTDs that have nothing to do with ldml. Ideally we'd remove the need for the attribute comparator, and only use the attribute ordering for writing out CLDRFiles. So we'd instead modify

XPathParts

public String toString(int style) {

...
to use the right comparator for the xml DTD for *that* path.

However, we'd need to approach this carefully—with a lot of testing, since there might be sideeffects to this change.

Attachments

Change History

comment:1 Changed 3 years ago by emmons

  • Status changed from new to assigned
  • Component changed from unknown to tools
  • Priority changed from assess to medium
  • Milestone changed from UNSCH to 25rc
  • Owner changed from anybody to mark
  • Type changed from unknown to enhancement

comment:2 Changed 3 years ago by mark

  • Component changed from tools to perf

comment:3 Changed 3 years ago by mark

  • Milestone changed from 25rc to 25final

comment:4 Changed 3 years ago by mark

  • Milestone changed from 25final to 26dsub

comment:5 Changed 3 years ago by mark

  • Milestone changed from 26dsub to 26rc

comment:6 Changed 3 years ago by mark

  • Milestone changed from 26rc to 27dsub

comment:7 Changed 3 years ago by markus

  • Phase set to dsub
  • Milestone changed from 27dsub to 27

comment:8 Changed 2 years ago by mark

  • Component changed from perf to infrastructure
  • Milestone changed from 27 to 28

comment:9 Changed 2 years ago by mark

  • Phase changed from dsub to rc

comment:10 Changed 2 years ago by srl

  • Status changed from assigned to accepted

comment:11 Changed 22 months ago by mark

  • Owner changed from mark to emmons

John, I think this is a dup of work you were doing. If so, please close it as such; otherwise send it back my way.

comment:12 Changed 22 months ago by emmons

  • Owner changed from emmons to mark

I took a look, and I think there is still some work here. I removed the elementOrdering and attributeOrdering stuff from the data and supplementalMetadata, but the attribute comparator in DtdData still looks like it's there.

Last edited 22 months ago by emmons (previous) (diff)

comment:13 Changed 21 months ago by mark

  • Milestone changed from 28 to 29

comment:14 Changed 20 months ago by emmons

  • Milestone changed from 29 to upcoming

Auto move of all 29 -> upcoming

View

Add a comment

Modify Ticket

Action
as accepted
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.