[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #7048(accepted enhancement)

Opened 4 years ago

Last modified 2 years ago

Provide feedback in ST for locales missing core data

Reported by: mark Owned by: srl
Component: survey Data Locale:
Phase: dsub Review:
Weeks: Data Xpath:
Xref:

ticket:6915

Attachments

Core_missing.PNG (24.3 KB) - added by tomzhang 3 years ago.

Change History

comment:1 Changed 4 years ago by emmons

  • Owner changed from anybody to mark
  • Status changed from new to assigned
  • Type changed from unknown to enhancement
  • Component changed from unknown to design
  • Milestone changed from UNSCH to 26dsub

comment:2 Changed 4 years ago by emmons

  • Status changed from assigned to design

comment:3 Changed 4 years ago by mark

I think these are the items remaining:

Steven, the function right now takes a CLDRFile and does not cache internally. The presumption is that you'd cache, because you know when a CLDRFile changes, and thus we'd need to regenerate. I could instead put in a cache and have the arguments be a Factory and a localeId, and have a separate method for to flush the cashe for a dirtied localeId. You'd need to call that whenever the CLDRFile changes. Would you like me to do that?

Code as is is difficult to use in SurveyTool. Example: File realDir = new File(CLDR_BASE_DIRECTORY + "/common/" + dir);

Issues:

  • It's best to use the base dir as an actual File instead of converting the path to a string.
  • Please defer the call CLDRConfig.getCldrBaseDirectory() when you actually need it. Static references are very bad, and cause me all kinds of headaches. Please defer CLDRConfig calls until absolutely necessary.
  • The code assumes common only - not seed. Please consider something like CLDRConfig.getInstance().getAllCLDRFilesEndingWith(".xml"). Our use of directories is pretty problematic. Lots of tools assume only common data, see ticket:6396

comment:4 Changed 3 years ago by mark

  • Summary changed from Restrict locales in ST (split) to Provide feedback in ST for locales missing core data

comment:5 follow-up: ↓ 10 Changed 3 years ago by mark

  • Status changed from design to accepted

Don't know what the blockage is.

The function call is simple, call

CoreCoverageInfo.getCoreCoverageInfo(CLDRFile file, Set<String> detailedErrors)

And then show the errors if any on the home screen, eg http://st.unicode.org/smoketest/v#/de//

Last edited 3 years ago by srl (previous) (diff)

comment:6 Changed 3 years ago by mark

  • Owner changed from mark to srl
  • Status changed from accepted to assigned

comment:7 Changed 3 years ago by mark

  • Component changed from design to survey

comment:8 Changed 3 years ago by srl

  • Milestone changed from 26dsub to 26dvet

comment:9 Changed 3 years ago by srl

  • Cc srl added
  • Owner changed from srl to tomzhang
  • Priority changed from assess to major

comment:10 in reply to: ↑ 5 Changed 3 years ago by srl

Replying to mark:

CoreCoverageInfo.getCoreCoverageInfo(CLDRFile file, Set<String> detailedErrors)

  1. add a SurveyAjax request that will call this function and send back the detailedErrors list via JSON
  2. have the home screen such as http://st.unicode.org/smoketest/v#/de// make this request (async) and display any errors.
  3. actually looking at showPossibleProblems() I think the right thing is to modify the possibleProblems SurveyAjax request to add to the JSON to include this list, then change showPossibleProblems() in survey.js to display them.

comment:11 Changed 3 years ago by tomzhang

  • Status changed from assigned to reviewing
  • Review set to mark

Add to existing "possible problems" with a type "warning". The change set is http://unicode.org/cldr/trac/changeset/10697 and I leave it on my branch.

Changed 3 years ago by tomzhang

comment:12 Changed 3 years ago by mark

  • Owner changed from tomzhang to srl

Am not the best at assessing the ST changes, so I hope you can take these.

comment:13 Changed 3 years ago by mark

  • Owner changed from srl to tomzhang
  • Review changed from mark to srl

Whoops: the batch modify was to the owner, not reviewer. Fixing here.

comment:14 Changed 3 years ago by markus

  • Phase set to dvet
  • Milestone changed from 26dvet to 26

comment:15 Changed 3 years ago by srl

  • Phase changed from dvet to dsub
  • Status changed from reviewing to accepted
  • Milestone changed from 26 to 27

comment:16 Changed 3 years ago by srl

  • Owner changed from tomzhang to emmons
  • Status changed from accepted to assigned

comment:17 Changed 3 years ago by srl

All changes are on the branch. John, please review and merge in milestone:27

comment:18 Changed 3 years ago by tomzhang

the branch is on branches/tomzhang/core_feedback, please check this branch to trunk

comment:19 Changed 3 years ago by emmons

  • Review srl deleted

comment:20 Changed 3 years ago by emmons

  • Phase changed from dsub to rc
  • Priority changed from major to medium
  • Milestone changed from 27 to 28

Just saw this on my queue (reports weren't showing it because the reviewer was set). The branch is huge and I don't think I'm going to get to this for 27.

comment:21 Changed 3 years ago by emmons

  • Owner changed from emmons to srl
  • Phase changed from rc to dsub
  • Priority changed from medium to major

Steven, I'm going to have to ask you to take over on this one - for 28.

comment:22 Changed 2 years ago by srl

  • Status changed from assigned to accepted

comment:23 Changed 2 years ago by emmons

  • Milestone changed from 28 to 29

Moving all survey related to 29dsub

comment:24 Changed 2 years ago by emmons

  • Milestone changed from 29 to upcoming

Automatic move of all 29 -> upcoming

View

Add a comment

Modify Ticket

Action
as accepted
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.