[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #7052(accepted tools)

Opened 3 years ago

Last modified 2 years ago

Create online tool to check keyboard layouts submitted through the online tool

Reported by: ribnitz Owned by: anybody
Component: unknown Data Locale:
Phase: dsub Review:
Weeks: Data Xpath:
Xref:

ticket:4953

Description

This is a continuation from ticket 4953, which introduced an API for keyboard checking. This bug is about wiring up the API to allow automatic checks of files submitted through the online tool.

Attachments

Change History

comment:1 Changed 3 years ago by ribnitz

Split this ticket from 4953; Did not have a chance to look at it in detail; probably means adapting upload.jsp/check.jsp in the Web-content folder, to (extract the file) and check each one in turn.

The "core" code is probably along the lines of:

(Reading the submitted file into a StringBuffer/StrinBuilder (s):

String kbdStr=s.toString();
String fixedDtdReference = kbdStr.replace("../dtd/ldmlKeyboard.dtd",

dtdLocation);

Reader r = new StringReader(fixedDtdReference);
Set<Exception> errors = new HashSet<>();
Keyboard.getKeyboard("uploaded kbd file", r, errors);

If the keyboard file is ok, the Set errors will probably be empty.

(upload.jsp, and check.jsp will probably need to be adapted to reject keyboard submissions that do not validate, ideally printing put the errors found)

Last edited 3 years ago by ribnitz (previous) (diff)

comment:2 Changed 3 years ago by ribnitz

Last edited 3 years ago by ribnitz (previous) (diff)

comment:3 Changed 3 years ago by emmons

  • Status changed from new to assigned
  • Component changed from unknown to tools
  • Priority changed from assess to medium
  • Milestone changed from UNSCH to 26rc
  • Owner changed from anybody to ribnitz
  • Type changed from unknown to enhancement

comment:4 Changed 3 years ago by mark

  • Owner changed from ribnitz to googler

comment:5 Changed 3 years ago by mark

  • Owner changed from googler to anybody
  • Milestone changed from 26rc to 27dsub

comment:6 Changed 3 years ago by markus

  • Phase set to dsub
  • Milestone changed from 27dsub to 27

comment:7 Changed 2 years ago by emmons

  • Milestone changed from 27 to UNSCH

Moving all 27+anybody tickets to UNSCH.

comment:8 Changed 2 years ago by markus

  • Type changed from enhancement to tools
  • Component changed from tools to unknown

comment:9 Changed 2 years ago by srl

  • Status changed from assigned to accepted
View

Add a comment

Modify Ticket

Action
as accepted
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.