[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #7093(accepted tools)

Opened 4 years ago

Last modified 2 years ago

Fix reformatting settings

Reported by: mark Owned by: yoshito
Component: infrastructure Data Locale:
Phase: dsub Review:
Weeks: Data Xpath:
Xref:

Description

When I went to review a change I found that the file had been reformatted. Unfortunately, lines that should have been broken were all mushed together.

Example:

    private static final String[] parseTestData = {
        "a: n is 1", "a:1",
        "a: n mod 10 is 2", "a:2,12,22",
        "a: n is not 1", "a:0,2,3,4,5",
        "a: n mod 3 is not 1", "a:0,2,3,5,6,8,9",
        "a: n in 2..5", "a:2,3,4,5",
        "a: n within 2..5", "a:2,3,4,5",
        "a: n not in 2..5", "a:0,1,6,7,8",
        "a: n not within 2..5", "a:0,1,6,7,8",
        "a: n mod 10 in 2..5", "a:2,3,4,5,12,13,14,15,22,23,24,25",
        "a: n mod 10 within 2..5", "a:2,3,4,5,12,13,14,15,22,23,24,25",
        "a: n mod 10 is 2 and n is not 12", "a:2,22,32,42",

turned into

    private static final String[] parseTestData = { "a: n is 1", "a:1", "a: n mod 10 is 2", "a:2,12,22",
            "a: n is not 1", "a:0,2,3,4,5", "a: n mod 3 is not 1", "a:0,2,3,5,6,8,9", "a: n in 2..5", "a:2,3,4,5",
            "a: n within 2..5", "a:2,3,4,5", "a: n not in 2..5", "a:0,1,6,7,8", "a: n not within 2..5", "a:0,1,6,7,8",
            "a: n mod 10 in 2..5", "a:2,3,4,5,12,13,14,15,22,23,24,25", "a: n mod 10 within 2..5",
            "a:2,3,4,5,12,13,14,15,22,23,24,25", "a: n mod 10 is 2 and n is not 12", "a:2,22,32,42",

This makes the code much harder to read. We should pick a better standard eclipse reformatting option that doesn't do this.

Attachments

Change History

comment:1 Changed 4 years ago by emmons

  • Status changed from new to assigned
  • Component changed from unknown to tools
  • Priority changed from assess to minor
  • Milestone changed from UNSCH to 25final
  • Owner changed from anybody to yoshito
  • Type changed from unknown to defect

comment:2 Changed 4 years ago by yoshito

  • Milestone changed from 25final to 26rc

Quoting my note sent to cldr-dev


The issue which I cannot resolve yet is array initializer, and the setting is in Line Wrapping tab. The current CLDR profile checks "Never join already wrapped lines" in the General settings section. But the general setting seems to have no effect for formatting array initializers. The setting dedicated for array initializers is found in Expressions - Array initializers. I tried some settings there, but could not get the behavior which I want.

I search internet and it looks some other folks are also struggling with array initializer formatting. And I could not find any reasonable solution other than protecting a block of code by @formatter:off explicitly.

-Yoshito


I tried some different options, but could not find a solution yet. Move to 26.

comment:3 Changed 3 years ago by yoshito

  • Milestone changed from 26rc to 27dsub

comment:4 Changed 3 years ago by markus

  • Phase set to dsub
  • Milestone changed from 27dsub to 27

comment:5 Changed 3 years ago by emmons

  • Milestone changed from 27 to 28

comment:6 Changed 2 years ago by markus

  • Type changed from defect to tools
  • Component changed from tools to unknown

comment:7 Changed 2 years ago by srl

  • Status changed from assigned to accepted

comment:8 Changed 2 years ago by emmons

  • Component changed from unknown to infrastructure

comment:9 Changed 2 years ago by emmons

  • Milestone changed from 28 to 28roll

Moving all outstanding 28 tickets to 28roll. We will discuss disposition of these at the next CLDR TC.

View

Add a comment

Modify Ticket

Action
as accepted
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.