[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #7279(closed: fixed)

Opened 5 years ago

Last modified 4 years ago

Test for hole in process: detect missing coverage level setting

Reported by: mark Owned by: emmons
Component: other Data Locale:
Phase: dsub Review: mark
Weeks: Data Xpath:
Xref:

Description

When you add new structure, and you forget to set PathHeader or other data, then we have a test that catches that.

Unfortunately, we are missing that for coverageLevels.xml. If you forget to make a change there, then your new, carefully added structure will be completely ignored. This is too fragile.

I propose that we add a test that does the following:

Cycle through every path in the English locale.

Skip the following:

if (path.endsWith("/alias")
path.startsWith("ldml/identity")) {

continue;

}
String locale = file.getSourceLocaleID(path, status);

if (!path.equals(status.pathWhereFound)
!locale.equals(fileLocale)) {

path is aliased, skip
continue;

}
if (config.getSupplementalDataInfo().isDeprecated(DtdType.ldml, path)) {

continue;

}

Of the remaining paths, which are non-deprecated, and not aliased in root, check against a set of known exception values, such as:

comprehensive:

cyclicNameSet,
metazone (Acre, Almaty, ...)
...

optional:
...

The above can be done with a RegexLookup. They don't have to be exact matches, just good enough to catch known exceptions that are not core..modern.

Anything path that makes it through this sieve, we flag as an error.

That way people find out when their structure is being ignored. If it is *meant* to be ignored, they can add to the list of exceptions.

There is a data file for looking at this in https://docs.google.com/spreadsheets/d/1t6P_12BYOCMMEp0dRyimrlA9h4PqMbJd4JOoHVjHQVE

For compactness, the paths have all attribute values replaced by stars, and the attributes are listed in the 3rd column, separated by |.

For example two patterns for listPattern are represented by the following:

ldml/listPatterns/listPattern[@type="*"]/listPatternPart[@type="*"]unit-narrow|2, unit-narrow|end

Attachments

Change History

comment:1 Changed 5 years ago by mark

  • Cc emmons added
  • Owner changed from anybody to mark
  • Priority changed from assess to major
  • Status changed from new to assigned
  • Milestone changed from UNSCH to 26dsub

comment:2 Changed 5 years ago by emmons

  • Milestone changed from 26dsub to 26dvet

Moving all 26dsub to 26dvet. Please assess the need to complete tickets by 26dvet, which is 2014-06-19

comment:3 Changed 5 years ago by mark

  • Milestone changed from 26dvet to 27dsub

comment:4 Changed 5 years ago by markus

  • Phase set to dsub
  • Milestone changed from 27dsub to 27

comment:5 Changed 4 years ago by mark

  • Component changed from unknown to test
  • Summary changed from Hole in process: coverage level setting to Test for hole in process: detect missing coverage level setting

comment:6 Changed 4 years ago by mark

  • Milestone changed from 27 to 28

comment:7 Changed 4 years ago by mark

  • Owner changed from mark to emmons

John, can you take this one?

comment:8 Changed 4 years ago by emmons

  • Priority changed from major to medium

comment:9 Changed 4 years ago by emmons

  • Status changed from assigned to reviewing
  • type changed from unknown to tools
  • Review set to mark

comment:10 Changed 4 years ago by markus

  • type changed from tools to unittest
  • Component changed from test to unknown

comment:11 Changed 4 years ago by mark

  • Status changed from reviewing to closed
  • Resolution set to fixed

comment:12 Changed 4 years ago by mark

  • Component changed from unknown to other
View

Add a comment

Modify Ticket

Action
as closed
Next status will be 'new'
Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.