[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #7911(accepted dtd)

Opened 3 years ago

Last modified 2 years ago

Nuke default attribute values

Reported by: mark Owned by: mark
Component: main Data Locale:
Phase: rc Review:
Weeks: Data Xpath:
Xref:

Description (last modified by mark) (diff)

The default attribute values cause problems, because people don't see an interpret them unless they are using a validating XML parser with the DTD, and they cause us problems because we don't realize that they are actually in the paths, so regexes and so on have to take care of them, and there is special code when writing to suppress them. We realized this fairly early on, and stopped using them.

However, we still have a bunch in our code.

Warning, default value «00:00» for	<ldml>…<weekendStart	time=…
Warning, default value «24:00» for	<ldml>…<weekendEnd	time=…
Warning, default value «26» for	<keyboard>…<version	cldrVersion=…
Warning, default value «26» for	<ldml>…<version	cldrVersion=…
Warning, default value «26» for	<ldmlBCP47>…<version	cldrVersion=…
Warning, default value «26» for	<supplementalData>…<version	cldrVersion=…
Warning, default value «both» for	<supplementalData>…<transform	direction=…
Warning, default value «external» for	<ldml>…<collation	visibility=…
Warning, default value «external» for	<supplementalData>…<transform	visibility=…
Warning, default value «false» for	<ldmlBCP47>…<attribute	deprecated=…
Warning, default value «false» for	<ldmlBCP47>…<type	deprecated=…
Warning, default value «false» for	<ldmlBCP47>…<key	deprecated=…
Warning, default value «standard» for	<ldml>…<scientificFormat	type=…
Warning, default value «standard» for	<ldml>…<currency	type=…
Warning, default value «standard» for	<ldml>…<percentFormat	type=…
Warning, default value «standard» for	<ldml>…<pattern	type=…
Warning, default value «standard» for	<ldml>…<timeFormat	type=…
Warning, default value «standard» for	<ldml>…<suppressions	type=…
Warning, default value «standard» for	<ldml>…<dateTimeFormat	type=…
Warning, default value «standard» for	<ldml>…<currencyFormat	type=…
Warning, default value «standard» for	<ldml>…<dateFormat	type=…
Warning, default value «standard» for	<ldml>…<decimalFormat	type=…
Warning, default value «standard» for	<ldml>…<collation	type=…

I'd like us to consider whether or not to nuke them. That would involve:

  1. remove the code that has the suppression. Then regenerate the data. That would insert the values into our .xml files.
  2. change the DTDs from using default values to having #IMPLIED
  3. add unit tests to ensure that our data always has these values.
  4. modify our tooling so that when we read older versions, the default values are inserted.
  5. like we do for some other fields (identity), write out the cldrVersion

One could theoretically change the DTD status to #REQUIRED. However, that would not allow our tooling to read older versions. The above maintains compatibility going forward.

Some alternatives:

  1. we could retain the cldrVersion item, since that is very specialized.
  2. ... (pending discussion)...

Attachments

Change History

comment:1 Changed 3 years ago by mark

  • Description modified (diff)

comment:2 Changed 3 years ago by mark

  • Owner changed from anybody to mark
  • Priority changed from assess to major
  • Status changed from new to assigned
  • Component changed from unknown to tools
  • Milestone changed from UNSCH to 27

Agreed to do #1 (except still suppressing deprecated items) and #3 add unit tests to ensure.

Might leave versions as is.

Add migration warning.

Last edited 3 years ago by markus (previous) (diff)

comment:3 Changed 3 years ago by mark

  • Phase changed from final to dsub
  • Milestone changed from 27 to 28

comment:4 Changed 3 years ago by mark

  • Component changed from tools to dtd

comment:5 Changed 3 years ago by mark

  • Phase changed from dsub to rc

comment:6 Changed 3 years ago by markus

  • Type set to dtd
  • Component changed from dtd to unknown

comment:7 Changed 3 years ago by srl

  • Status changed from assigned to accepted

comment:8 Changed 2 years ago by emmons

  • Component changed from unknown to main

comment:9 Changed 2 years ago by mark

  • Milestone changed from 28 to 29

comment:10 Changed 2 years ago by emmons

  • Milestone changed from 29 to upcoming

Automatic move of all 29 -> upcoming

View

Add a comment

Modify Ticket

Action
as accepted
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.