[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #8348(accepted tools)

Opened 2 years ago

Last modified 2 years ago

cachRounding not being transferred to ICU

Reported by: travis Owned by: travis
Component: ldml2icu Data Locale:
Phase: rc Review:
Weeks: Data Xpath:
Xref:

Description (last modified by travis) (diff)

The new cash rounding attribute is not being moved to ICU for CHF and CAD.

ldml2icu_supplemental.txt contains a new xpath mapping for the new cash rounding attribute, but this xpath comes after the more general xpath that does not include the cash rounding attribute in ldml2icu_supplemental.txt. Therefore currencies with cash rounding match the more general xpath mapping that does not include rules for cash rounding, so the cash rounding never makes it to ICU.

Expected behavior:

The new, more specific xpath mapping with the cash rounding rule should come before the more general xpath mapping without the cash rounding rule in ldml2icu_supplemental.txt

This is what I want to change at line 47. I want the more specific xpaths to come before the more general ones.

Before (more general xpath comes first):

//supplementalData/currencyData/fractions/info[@iso4217="(%W)"][@digits="(%N)"][@rounding="(%N)"] ; /CurrencyMeta/$1:intvector ; values=$2 $3 $2 $3
//supplementalData/currencyData/fractions/info[@iso4217="(%W)"][@digits="(%N)"][@rounding="(%N)"][@cashRounding="(%N)"] ; /CurrencyMeta/$1:intvector ; values=$2 $3 $2 $4
//supplementalData/currencyData/fractions/info[@iso4217="(%W)"][@digits="(%N)"][@rounding="(%N)"][@cashDigits="(%N)"][@cashRounding="(%N)"] ; /CurrencyMeta/$1:intvector ; values=$2 $3 $4 $5

After (more specific xpath comes first):

//supplementalData/currencyData/fractions/info[@iso4217="(%W)"][@digits="(%N)"][@rounding="(%N)"][@cashDigits="(%N)"][@cashRounding="(%N)"] ; /CurrencyMeta/$1:intvector ; values=$2 $3 $4 $5
//supplementalData/currencyData/fractions/info[@iso4217="(%W)"][@digits="(%N)"][@rounding="(%N)"][@cashRounding="(%N)"] ; /CurrencyMeta/$1:intvector ; values=$2 $3 $2 $4
//supplementalData/currencyData/fractions/info[@iso4217="(%W)"][@digits="(%N)"][@rounding="(%N)"] ; /CurrencyMeta/$1:intvector ; values=$2 $3 $2 $3

Doing this change fixes this issue and allows currency rounding to be correctly transferred to ICU.

Attachments

Change History

comment:1 Changed 2 years ago by travis

  • Description modified (diff)

comment:2 Changed 2 years ago by emmons

  • Status changed from new to assigned
  • Component changed from unknown to ldml2icu
  • Priority changed from assess to major
  • Phase changed from dsub to rc
  • Milestone changed from UNSCH to 28
  • Owner changed from anybody to travis
  • Type set to tools

comment:3 Changed 2 years ago by srl

  • Status changed from assigned to accepted

comment:4 Changed 2 years ago by emmons

  • Milestone changed from 28 to 28roll

Moving all outstanding 28 tickets to 28roll. We will discuss disposition of these at the next CLDR TC.

View

Add a comment

Modify Ticket

Action
as accepted
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.