[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #9029(closed tools: fixed)

Opened 19 months ago

Last modified 2 months ago

supplemental/dayPeriods missing GitHub/npm

Reported by: malte.wedel@… Owned by: emmons
Component: json Data Locale:
Phase: rc Review: pedberg
Weeks: Data Xpath:
Xref:

ticket:9841

Description

Hello CLDR Team,

I tried to do a proper implementation of the period symbols "a", "b" and "B", but failed to find the dayPeriod rules in the JSON files provided on GitHub/npm. In the XML data there is a file supplemental/dayPeriods.xml, but no equivalent JSON does exist.

Best Regards,
Malte Wedel

Attachments

Change History

comment:1 Changed 18 months ago by emmons

  • Status changed from new to accepted
  • Priority changed from assess to medium
  • Phase changed from dsub to rc
  • Milestone changed from UNSCH to upcoming
  • Owner changed from anybody to emmons
  • Type changed from unknown to tools

Let me see if I can get the converter to work properly for day periods.

comment:2 Changed 7 months ago by srl

Fix:

Index: tools/java/org/unicode/cldr/json/LdmlConvertRules.java
===================================================================
--- tools/java/org/unicode/cldr/json/LdmlConvertRules.java	(revision 13019)
+++ tools/java/org/unicode/cldr/json/LdmlConvertRules.java	(working copy)
@@ -14,7 +14,7 @@
/** File sets that will not be processed in JSON transformation. */
public static final ImmutableSet<String> IGNORE_FILE_SET =
- ImmutableSet.of("attributeValueValidity", "coverageLevels", "dayPeriods", "postalCodeData", "pluralRanges", "subdivisions");
+ ImmutableSet.of("attributeValueValidity", "coverageLevels", "postalCodeData", "pluralRanges", "subdivisions");
/**
* The attribute list that should become part of the name in form of
Last edited 7 months ago by srl (previous) (diff)

comment:3 Changed 7 months ago by srl

cldr-sideways-users was checked in mistakenly. it should be part of another ticket.

comment:4 Changed 7 months ago by srl

  • Status changed from accepted to reviewing
  • Xref set to 9841
  • Review set to pedberg

added ticket:9841 for the cldr-sideways-users code

comment:5 Changed 7 months ago by pedberg

  • Status changed from reviewing to closed
  • Resolution set to fixed

comment:6 in reply to: ↑ description Changed 2 months ago by Ryan Murray <rjkmurray89@…>

Replying to malte.wedel@…:

Hello CLDR Team,

I tried to do a proper implementation of the period symbols "a", "b" and "B", but failed to find the dayPeriod rules in the JSON files provided on GitHub/npm. In the XML data there is a file supplemental/dayPeriods.xml, but no equivalent JSON does exist.

Best Regards,
Malte Wedel

View

Add a comment

Modify Ticket

Action
as closed
Next status will be 'new'
Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.