[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #9276(accepted tools)

Opened 15 months ago

Last modified 15 months ago

Fix exhaustive tests

Reported by: mark Owned by: mark
Component: unknown Data Locale:
Phase: rc Review:
Weeks: Data Xpath:
Xref:

Description

Some of our tests are completely disabled if getInclusion() > 5. That means that either

  1. we check in tests thinking all is fine, only to have them break the exhaustive build, or
  2. we always have to run the exhaustive tests, which defeats the purpose.

Typically the reason the tests are long is that they are cycling completely through a set of elements. A better way to get the speedup we need is to use the following strategy:

At the top, set:

int maxPerDirectory = getInclusion() <= 5 ? 20 : Integer.MAX_VALUE;

In the loop, do:

int count = 0;
for (String file : dir2.list()) {

...

if (++count > maxPerDirectory) {

break;

}

Attachments

Change History

comment:1 Changed 15 months ago by emmons

  • Status changed from new to accepted
  • Priority changed from assess to minor
  • Phase changed from dsub to rc
  • Milestone changed from UNSCH to upcoming
  • Owner changed from anybody to mark
  • Type changed from unknown to tools
View

Add a comment

Modify Ticket

Action
as accepted
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.