[Unicode]   Common Locale Data Repository : Bug Tracking Home | Site Map | Search
 
Modify

CLDR Ticket #9733(accepted tools)

Opened 16 months ago

Last modified 3 months ago

Change CLDRModify minimize

Reported by: mark Owned by: mark
Component: other Data Locale:
Phase: dsub Review:
Weeks: Data Xpath:
Xref:

Description

Change to use the bailey value instead of the parent value. This will also minimize sideways aliasing, for smaller files.

This is done in

public CLDRFile removeDuplicates(CLDRFile other, boolean butComment, RetentionTest keepIfMatches,

...

String otherValue = other.dataSource.getValueAtPath(otherXpath);

=>

String otherValue = dataSource.getBaileyValue(otherXpath, pathWhereFound, localeWhereFound) ;

and then replacing the steps that ensure the full paths are the same:

                            String currentFullXPath = dataSource.getFullPath(xpath);
                            String otherFullXPath = other.dataSource.getFullPath(otherXpath);
                            if (!equalsIgnoringDraft(currentFullXPath, otherFullXPath)) {
                                logicDuplicate = false;
                                continue;
                            }

The check instead should be that no @VALUE attributes are different, which can be done by getting the XPathParts, and then testing with the DtdData.

Attachments

Change History

comment:1 Changed 11 months ago by pedberg

  • Status changed from new to accepted
  • Cc emmons added
  • Component changed from unknown to other
  • Milestone changed from UNSCH to 31
  • Owner changed from anybody to mark
  • Type changed from unknown to tools

John has some other bugs for minimize

comment:2 Changed 11 months ago by mark

  • Phase changed from dsub to dvet

comment:3 Changed 10 months ago by mark

  • Phase changed from dvet to dsub
  • Milestone changed from 31 to 32

comment:4 Changed 10 months ago by mark

Currently, CLDRModify doesn't remove items that are in a "base" locale (root.xml or one level below root, like fr.xml). That is so that the base languages can be "self contained".

So will need to check that code path so that items can be removed from a base locale, if their path is different, such as a sideways or alt inheritance.

However, we should also add an input parameter to do an exhaustive removal, which removes from every locale: even base locales and root. That can be used for building clients like ICU, so that we get rid of the maximal amount of redundant data.

comment:5 Changed 3 months ago by mark

  • Milestone changed from 32 to 33
View

Add a comment

Modify Ticket

Action
as accepted
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.